Skip to content

Actions: Remove preview notice, minor help and metadata fixes #19307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 16, 2025

Conversation

adityasharad
Copy link
Collaborator

Remove the public preview notice for the next publish.
Various corrections to query help.
Add missing security-severity for the excessive secrets exposure query.

@github-actions github-actions bot added documentation Actions Analysis of GitHub Actions labels Apr 14, 2025
@adityasharad adityasharad marked this pull request as ready for review April 15, 2025 17:19
@Copilot Copilot AI review requested due to automatic review settings April 15, 2025 17:19
@adityasharad adityasharad requested a review from a team as a code owner April 15, 2025 17:19
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the public preview notice, makes minor corrections to query help content, and adds a missing security-severity metadata to a query.

  • Added metadata for excessive secrets exposure query
  • Corrected typos and punctuation for clarity in security issue documents
  • Updated wording in the exploitation section for improved readability

Reviewed Changes

Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.

File Description
actions/ql/src/change-notes/2025-04-14-excessive-secrets-exposure-security-severity.md Adds metadata with security severity and notes for the query
actions/ql/src/Security/CWE-312/UnmaskedSecretExposure.md Fixes grammatical errors and improves punctuation in the description and recommendations
actions/ql/src/Security/CWE-077/EnvVarInjectionMedium.md Refines wording in the exploitation section for better clarity
Files not reviewed (3)
  • actions/ql/src/Security/CWE-275/MissingActionsPermissions.ql: Language not supported
  • actions/ql/src/Security/CWE-312/ExcessiveSecretsExposure.ql: Language not supported
  • docs/codeql/reusables/supported-versions-compilers.rst: Language not supported

Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look great 💖

@adityasharad adityasharad merged commit c4e8b1a into github:main Apr 16, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions Analysis of GitHub Actions documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants